Project

General

Profile

Bug #4836

qfq: multiple entries in table after several clicks on save

Added by Karin Niffeler over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Target version:
Start date:
27.10.2017
Due date:
% Done:

0%

Estimated time:
Discuss:

Description

Hi,

Despite the save-button turns orange after a click on save and a blocked-icon is visible, the save-process is not really blocked anymore.
For each click on the form-save-button, there will be an entry in the database.

Many thanks,
Karin


Related issues

Related to QFQ - Feature #4281: Save: a) spinning wheel, b) Doppeltes Speichern verhindernClosed2017-08-23

Associated revisions

Revision 46a6af99
Added by Benjamin Baer over 2 years ago

Merge branch 'bug_4836' into 'master'

Created a saveInProgress Variable

See merge request typo3/qfq!26

History

#1 Updated by Karin Niffeler over 2 years ago

  • Tracker changed from Support to Bug

#2 Updated by Carsten Rose over 2 years ago

  • Target version changed from 0.24 to 0.25

#3 Updated by Carsten Rose over 2 years ago

  • Target version changed from 0.25 to next

#4 Updated by Carsten Rose over 2 years ago

  • Related to Feature #4281: Save: a) spinning wheel, b) Doppeltes Speichern verhindern added

#5 Updated by Carsten Rose over 2 years ago

Bug confirmed in 0.25.1 with Opera und Network Speed 3G.

Status bevor BB anfing an dem 4281 zu arbeiten:
https://git.math.uzh.ch/typo3/qfq/commit/d343cd13fda8bbd552497dc76fff30e6bc76ffb0

Merge von 4281 in master
https://git.math.uzh.ch/typo3/qfq/commit/086f18bd25cac14e6481e6cbf515ec006cef2b4f

Aktuell sehe ich keine Veraenderung des relevantes Codes zwischen 24.8.17 (v0.19.6) (Bug fix) und 4.11.17 (v0.25.1) (Bug wieder aufgetreten).
Achtung: Das der Bug in v0.19.6 wirklich behoben ist, habe ich nicht ueberprueft!!

Mir ist nicht klar warum die folgenden 2x2 Zeilen Code den Bug fixen. Reicht es die CSS 'disabled' Klasse hinzuzufuegen um einen Mausklick zu unterdruecken??

Form.js: $("#save-button")... Zeilen sind neu (vorletzte und vorvorletzte).

    n.Form.prototype.ajaxSuccessHandler = function (data, textStatus, jqXHR) {
        this.resetFormChangedState();
        this.eventEmitter.emitEvent('form.submit.successful',
            n.EventEmitter.makePayload(this, data, {
                textStatus: textStatus,
                jqXHR: jqXHR
            }));
        $("#save-button").removeClass('btn-warning active disabled');
        $("#save-button").addClass('btn-default');
    };

QfqForm.js: this.getSaveButton().... Zeilen sind neu (4.letzte & 3.letzte)

    n.QfqForm.prototype.handleSaveClick = function () {
        this.lastButtonPress = "save";
        n.Log.debug("save click");
        this.getSaveButton().removeClass('btn-info');
        this.getSaveButton().addClass('btn-warning active disabled');
        this.submit();
    };

#6 Updated by Carsten Rose over 2 years ago

  • Subject changed from qfq: entries in table after several clicks on save to qfq: multiple entries in table after several clicks on save
  • Status changed from New to Closed

Fixed in 0.25.2

#7 Updated by Carsten Rose about 2 years ago

  • Target version changed from next to 18.4

Also available in: Atom PDF