Project

General

Profile

Actions

Bug #18031

closed

PHPUnit-Tests funktionieren nicht mit der neuen PHP-Version

Added by Zhoujie Li 4 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Carsten Rose
Target version:
Start date:
02.10.2019
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Discuss:
Prio Planung:
No
Vote:

Description

Wir sind auf ein Problem gestossen, bei dem unsere bestehenden PHPUnit-Tests nach dem Update auf die neueste PHP-Version nicht wie erwartet ausgeführt werden. Dies hat zu mehreren Testfehlern geführt.

Es wäre sinnvoll, die Tests zu überarbeiten und zu refaktorisieren.


Files


Subtasks 1 (0 open1 closed)

Bug #9281: Allow STRICT_TRANS_TABLESClosedCarsten Rose02.10.2019

Actions

Related issues

Related to QFQ - Bug #17257: Migrate QFQ system tables: set default valueClosedCarsten Rose09.11.2023

Actions
Actions #1

Updated by Zhoujie Li 4 months ago

PHPUnitTest Fix

class: BuildFormPlainTest

function : testBuildSubrecord()

Zeile: 417

Actions #2

Updated by Zhoujie Li 4 months ago

class: Database

class: DatabaseTest

Zeile: 443-449

   $version = $this->dbArray[DB_INDEX_DEFAULT]->sql("SELECT @@version;", ROW_IMPLODE_ALL);
        preg_match('/^\d+(\.\d+)*(\.\d+)/', $version, $matches);
        $numericVersion = $matches[0];
        if (version_compare($numericVersion, '10.3', '<')) {
            # In 10.2,10.2:  CURRENT_TIMESTAMP
            $expected[6] = ['Field' => 'modified', 'Type' => "datetime", 'Null' => 'YES', 'Key' => '', 'Default' => 'CURRENT_TIMESTAMP', 'Extra' => 'on update CURRENT_TIMESTAMP'];
        }

class: EvaluateTest

Zeile: 109

 preg_match('/^\d+(\.\d+)*(\.\d+)/', $version, $matches);
        $numericVersion = $matches[0];
        if (version_compare($numericVersion, '10.3', '<')) {
            # In 10.2,10.2:  CURRENT_TIMESTAMP
            $expected = "idbigint(20)NOPRIauto_incrementnamevarchar(128)YESfirstNamevarchar(128)YESadrIdint(11)NO0genderenum('','male','female')NOmalegroupsset('','a','b','c')NOmodifiedtimestampNOCURRENT_TIMESTAMPon update CURRENT_TIMESTAMPcreateddatetimeNO";
        }
Actions #3

Updated by Carsten Rose 4 months ago

  • Related to Bug #17257: Migrate QFQ system tables: set default value added
Actions #4

Updated by Enis Nuredini 4 months ago

  • Status changed from New to In Progress
  • Assignee changed from Enis Nuredini to Carsten Rose

Aktuelle Umsetzung im Branch läuft bei den Tests durch.

Ubuntu Update des Git Containers muss noch erfolgen.

Actions #5

Updated by Carsten Rose 3 months ago

Actions #6

Updated by Carsten Rose about 1 month ago

  • Target version changed from 24.7.0 to 24.5.0
Actions #7

Updated by Carsten Rose about 1 month ago

  • Status changed from In Progress to Closed
Actions

Also available in: Atom PDF